Add Links for uninstall templates From Item Form#186
Open
tsmr wants to merge 13 commits intopluginsGLPI:mainfrom
Open
Add Links for uninstall templates From Item Form#186tsmr wants to merge 13 commits intopluginsGLPI:mainfrom
tsmr wants to merge 13 commits intopluginsGLPI:mainfrom
Conversation
Contributor
|
@tsmr |
Rom1-B
requested changes
Mar 9, 2026
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
stonebuzz
requested changes
Mar 10, 2026
Co-authored-by: Stanislas <skita@teclib.com>
Rom1-B
reviewed
Mar 12, 2026
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
stonebuzz
requested changes
Mar 12, 2026
Co-authored-by: Stanislas <skita@teclib.com>
stonebuzz
requested changes
Apr 21, 2026
Comment on lines
+1066
to
+1069
| ob_start(); | ||
| self::showFormUninstallation($item->getID(), $item, $users_id, $templates_id); | ||
| $html_modal = ob_get_contents(); | ||
| ob_end_clean(); |
Contributor
There was a problem hiding this comment.
Using output buffering to capture HTML from a method that relies on echo is a fragile pattern and should be avoided.
stonebuzz
requested changes
Apr 21, 2026
Comment on lines
+1061
to
+1063
| echo "<a href='#' id='" . $templates_id . "' class='btn btn-primary me-2'>" | ||
| . $data['name'] | ||
| . "</a>"; |
Contributor
There was a problem hiding this comment.
The value of $data['name'] comes from the database and is rendered without proper escaping. It should be sanitized using __s(), to prevent potential security issues such as XSS.
Contributor
There was a problem hiding this comment.
The best approach would be to switch to Twig to remove all the echo statements from the function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Add Links for uninstall templates From Item Form (if not replace state dropdown
Screenshots (if appropriate):